Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fee-Abstraction to Hub #2702

Closed
wants to merge 15 commits into from

Conversation

GNaD13
Copy link

@GNaD13 GNaD13 commented Aug 21, 2023

Add Fee-abstraction module to the Hub
Follow by Proposal 810

This PR will:

  • Add Feeabs module
  • Remove fee condition to check gas fee in globalfee ante (now globalfee will only check the min-gas-price and bypass msg, All fee condition will be checked in feeabs ante)
  • Add some func to globalfee to check min-gas-price
  • Add FeeAbstrationMempoolFeeDecorator ante and replace sdk DeductFeeDecorator with FeeAbstractionDeductFeeDecorate

@faddat
Copy link
Contributor

faddat commented Aug 22, 2023

Hey I just did a brief review of this, wanted to let you know that it's important that for the hub that we use the ics-lsm branch of SDK 45.

Really looking forward to seeing this one come along🙂

@GNaD13 GNaD13 marked this pull request as ready for review August 28, 2023 14:23
@mpoke
Copy link
Contributor

mpoke commented Aug 29, 2023

@GNaD13 Thanks for opening the PR. Could you please rebase to https://github.com/cosmos/gaia/tree/feat/fee-abstraction? To add the module to main, the following are still needed:

  • e2e tests to check the functionality of the module
  • documentation

Once the feature is complete, we merge the entire feature branch to main.

@GNaD13 GNaD13 changed the base branch from main to feat/fee-abstraction August 29, 2023 10:56
@GNaD13 GNaD13 marked this pull request as draft August 29, 2023 10:56
@GNaD13 GNaD13 marked this pull request as ready for review September 8, 2023 13:45
@GNaD13
Copy link
Author

GNaD13 commented Sep 8, 2023

Fee-Abstraction module not yet audited. I'm taking it out of draft because I think that this should be a good final form for the code. Likely you do want to review it, but probably right now it shouldn't be merged because we are completing the audit.

Copy link

github-actions bot commented Nov 3, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 3, 2023
@github-actions github-actions bot closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants